test: unit test multiple node versions in separate jobs #23714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
unit-node16
branch
3 times, most recently
from
6c72d08 to
4f29f08
Compare
jbedard
commented
Aug 10, 2022
| equal: [*default_nodeversion_major, << parameters.nodeversion >>] | ||
| steps: | ||
| - run: | ||
| command: yarn bazel test --test_tag_filters=-node16,-node<< parameters.nodeversion >>-broken //packages/... |
There was a problem hiding this comment.
This ugly condition (and opposite below) is so this one catches all node14 and non-versioned, while the other is all specifically for node16. Could add more in the future by adding to the array at the top of the file and add the -node## to this line.
jbedard
force-pushed
the
unit-node16
branch
2 times, most recently
from
481e5e9 to
faa6c2f
Compare
alan-agius4
added
target: patch
alan-agius4
approved these changes
Sep 14, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the multiple node versions/toolchains but runs them as separate circleci jobs to not overload the executors. Also disabling the node16 version of the one test that seems to crash with node16.